Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No 'invalid date' error in other places #1071

Open
3 tasks
Destroy666x opened this issue Jul 30, 2014 · 6 comments · May be fixed by #4246
Open
3 tasks

No 'invalid date' error in other places #1071

Destroy666x opened this issue Jul 30, 2014 · 6 comments · May be fixed by #4246
Assignees
@effone
Labels
b:1.8 Branch: 1.8.x s:confirmed Status: Confirmed. Retested and found the issue exists s:in-progress Status: In Progress. Some work completed t:bug Type: Bug. An issue causing error / flaw / malfunction

Comments

@Destroy666x
Copy link
Contributor

Continuation of this:
#652

The date inputs aren't also validated in the following places:

  • calendar.php - add/edit private/public event start/end date
  • moderation.php - delayed moderation date (delayed moderation doesn't seem to work for me at all with inline moderation - someone should create new issue if confirmed)
  • usercp.php, ACP and modcp.php - away date (it shows wrong date instead, so for example 31st Feb shows March) - this also applies to 1.6.

There are probably more but I can't remember other places atm.
@Destroy666x Destroy666x added this to the 1.8.0 milestone Jul 30, 2014
@JN-Jones
Copy link
Contributor

Are they fixed in 1.6?

@Destroy666x
Copy link
Contributor Author

calendar.php event seems to be checked in 1.6.
moderation.php delayed moderation date is a new feature introduced in 1.8.
usercp.php and modcp.php away is also bugged in 1.6 (added label). ACP needs validation probably too (a job for userhandler?).

@DiogoParrinha DiogoParrinha modified the milestones: 1.8.0, 1.6.15 Jul 30, 2014
@DiogoParrinha DiogoParrinha removed the 1.6 label Aug 2, 2014
@DiogoParrinha DiogoParrinha modified the milestones: 1.6.15, 1.8.1 Aug 2, 2014
@DiogoParrinha DiogoParrinha modified the milestones: 1.8.1, 1.8.2 Oct 4, 2014
@DiogoParrinha DiogoParrinha modified the milestones: 1.8.4, 1.8.3 Nov 18, 2014
@Sama34 Sama34 self-assigned this Dec 27, 2014
@JN-Jones JN-Jones modified the milestones: 1.8.5, 1.8.6 Apr 30, 2015
@JN-Jones JN-Jones modified the milestones: 1.8.6, 1.8.7 Aug 26, 2015
@Stefan-MyBB Stefan-MyBB modified the milestones: 1.8.7, 1.8.8 Mar 2, 2016
@Stefan-MyBB Stefan-MyBB modified the milestones: 1.8.9, 1.8.10 Dec 15, 2016
@Stefan-MyBB Stefan-MyBB modified the milestones: 1.8.10, 1.8.11 Jan 8, 2017
@Stefan-MyBB Stefan-MyBB modified the milestones: 1.8.11, 1.8.12 Apr 1, 2017
@Stefan-MyBB Stefan-MyBB modified the milestones: 1.8.12, 1.8.13 May 22, 2017
@Stefan-MyBB Stefan-MyBB modified the milestones: 1.8.13, 1.8.14 Nov 6, 2017
@dvz dvz removed this from the 1.8.14 milestone Nov 22, 2017
@effone
Copy link
Member

effone commented May 9, 2018

While tried to working on it; observed few errors are inline, few errors are in a new error page. Should there be any consistency or just let them be as is focusing in the main issue?
@Sama34 @euantorano

@effone effone self-assigned this May 9, 2018
@euantorano
Copy link
Member

euantorano commented May 9, 2018 via email

@Sama34
Copy link
Contributor

Sama34 commented May 11, 2018

I agree we should focus on the main issue and only update if it is easy and quick to do.

@effone effone mentioned this issue May 15, 2018
Closed
9 tasks
@effone effone added the s:in-progress Status: In Progress. Some work completed label May 15, 2018
@effone effone modified the milestone: 1.8.16 May 15, 2018
@effone effone removed the s:in-progress Status: In Progress. Some work completed label Jun 6, 2018
@effone effone linked a pull request Feb 2, 2021 that will close this issue
Draft
12 tasks
@effone effone added the s:in-progress Status: In Progress. Some work completed label Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@effone effone

Labels
b:1.8 Branch: 1.8.x s:confirmed Status: Confirmed. Retested and found the issue exists s:in-progress Status: In Progress. Some work completed t:bug Type: Bug. An issue causing error / flaw / malfunction
Projects
None yet
Milestone
No milestone
8 participants
@Stefan-MyBB @euantorano @DiogoParrinha @Sama34 @JN-Jones @Destroy666x @dvz @effone