Add search to dropdown component #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgregs32
force-pushed
the
chris/add-search-to-dropdown-component
branch
3 times, most recently
from
200bbda
to
3e7b912
Compare
cerinman
reviewed
Jul 29, 2019
cerinman
reviewed
Jul 29, 2019
paniclater
reviewed
Jul 29, 2019
cerinman
reviewed
Jul 29, 2019
cerinman
reviewed
Jul 29, 2019
cerinman
reviewed
Jul 29, 2019
cgregs32
force-pushed
the
chris/add-search-to-dropdown-component
branch
from
73ede10
to
f7ae456
Compare
cerinman
reviewed
Jul 30, 2019
cgregs32
commented
Jul 31, 2019
cerinman
reviewed
Aug 1, 2019
cgregs32
force-pushed
the
chris/add-search-to-dropdown-component
branch
from
2fe27e8
to
8d564ac
Compare
|
@cerinman |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#832
Adds the ability to include search component to select component via
withSearchpropUtilizes
Searchcomponent withinselectcomponent to be able to filter longer lists of options.withSearchdefault to false, so this change will not affect existing calls to theselectcomponent