Add bool and function to toggle data label changing on hover #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paniclater
reviewed
Jan 30, 2019
src/components/DonutChart.js
Outdated
| @@ -38,6 +38,8 @@ class DonutChart extends React.Component { | |||
| showBaseArc: PropTypes.bool, | |||
| showDataLabel: PropTypes.bool, | |||
| theme: themeShape, | |||
| toggleDataLabelOnHover: PropTypes.bool, | |||
There was a problem hiding this comment.
this name makes it look like a function or similar to me. I prefer booleans to start with the prefix is, are, should or similar. In this case I think something like "shouldTriggerSliceHoverEvents" or "shouldToggleDataLabelOnHover" would be better options.
There was a problem hiding this comment.
I'll use shouldToggleDataLabelOnHover. Thanks, this was a difficult thing to try and name
|
The failing build here is due to an npm dependency in the docs having a vulnerability. If you pull master and merge it into your branch the build should succeed. |
cerinman
reviewed
Jan 30, 2019
cerinman
reviewed
Jan 30, 2019
| showBaseArc: PropTypes.bool, | ||
| showDataLabel: PropTypes.bool, | ||
| theme: themeShape, | ||
|
|
There was a problem hiding this comment.
Doesn't look like we need this line break. Can you remove it?
cerinman
reviewed
Jan 30, 2019
cerinman
reviewed
Jan 30, 2019
|
|
cerinman
added a commit
that referenced
this pull request
Jan 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #818
Change:
Add an additional boolean value that allows you to toggle this hover functionality on or off. For specific cases where there is no relevant data associated with a slice and you want to hover over a slice without animation AND without updating the data label in the center of the chart.
Update docs to describe new bool.