-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate Packages #812
Separate Packages #812
Conversation
I am not sure the package.json files and scripts are lining up. A fresh install of this for me yields:
Even if I have installed the docs package. I think this makes sense, given that the dev server is not installed in the lib's dev dependencies, so it wouldn't be able to find it in it's environment. |
Did you do a fresh install on both the package.json and the docs/package.json? I have been running I tried to pare them down to only what was needed, but I may have missed something. |
Looking now, I am missing the |
Yeah that is with a fresh install in both and yeah, it is missing the dev server in the main. This has me thinking about what should be where. 🤔 |
Closing this in favor of #813 |
This separates the package.json files out again and moves the webpack config into the docs directory.
Issue: #811
This pulls in Sam's bundle size check on the docs bundle.
It also removes the
.npmignore
file. From what I have read, this can lead to issues wherenpm
honors this over the.gitignore
file. This can lead to files ignored in git being added accidentally to the npm package. Since we are specifying thefiles: 'dist'
now, those are the only ones included and the ignore isn't needed..travis.yml
Changelog.js
docs/package.json
webpack.config.js
hot
andinline
since they are in the scripteval-source-map
to use original code instead of generated.babelrc
isn't picked up so they need to be added here, also.