Wikibase client (read only)

[PierreSelim]

I've been working on implementation of reading method of the wikibase API:

• wikibase_item() in the page module
• WikiBaseSite and entities() in the client module
• entity module. The Claim class is mainly an helper to access dictionnary returned by wbgetclaims or wbgetentities method from API

Example of how it works:

import mwclient

site = mwclient.Site(('https', 'en.wikipedia.org'))
article = site.Pages['Paris']
item = article.wikibase_item()

# wikibase repo
wikidata = site.wikibase()
print wikidata

# Claims
claims = item.claims()
for claim in claims:
    print claim
    print claim.value

# Only coordinates
for claim in item.claims(prop=['P625']):
    print "%f, %f" % (claim.latitude, claim.longitude)

# Only subdivision (Paris subdivision are Items)
for claim in item.claims(prop=['P150']):
    print claim.item

wikidata = mwclient.WikiBaseSite(('https', 'www.wikidata.org'))
entities = wikidata.entities(ids=['Q42', 'P238'])
for entity in entities:
    print entity
    if entity.entity == 'P238':
        for claim in entity.claims(prop=['P1659']):
            print claim.property_value
# <Property object P238 (('https', 'www.wikidata.org'))>
# <Property object P239 (('https', 'www.wikidata.org'))>
# <Property object P229 (('https', 'www.wikidata.org'))>
# <Item object Q42 (('https', 'www.wikidata.org'))>

[landscape-bot]

Repository health increased by 0.36% when pulling a660b7d on PierreSelim:wikibase into 2a42d77 on mwclient:master.

• 3 new problems were found (including 0 errors and 2 code smells).
• No problems were fixed.

[danmichaelo]

Thanks for pushing this! I'll try to read over the code in the weekend.

[PierreSelim]

@danmichaelo do not hesitate to comment things that you don't like in my code :)

[danmichaelo]

When doing tab completion on the Site object, it's a bit confusing to have both wikibase and wikibase_site. I'll suggest prefixing the latter with _. And btw. what about making it a property? It's about time we start using properties in mwclient – and I noticed you've already used properties some places :) How about this?

    @property
    def wikibase_repo(self):
        """
        Get a reference to the associated Wikibase repository site.

        Returns:
            a WikiBaseSite object
        """
        if self._wikibase_repo is None:
            result = self.api('query', meta='wikibase')
            url = result['query']['wikibase']['repo']['url']
            host = url['base'].replace('//', '')
            path = url['scriptpath'] + "/"
            self._wikibase_repo = WikiBaseSite(('https', host),
                                              path=path,
                                              pool=self.connection)
        return self._wikibase_repo

I guess Page.wikibase_item could also be a property

[danmichaelo]

Prefix this one with underscore as well?

[PierreSelim]

That would be the logic thing to do +1 :)

[danmichaelo]

And please remove this file ;)

[PierreSelim]

I'm ashamed this got pushed ... I just rebased it ^_^

[waldyrious]

@PierreSelim and @danmichaelo, since these things sometimes fall off our radar, I'm just pinging you in case there's something other than dev work (e.g. a comment to respond) stalling the discussion. What's the status, what needs to be done?

[PierreSelim]

@waldyrious and @danmichaelo true this has totally fell off my radar, I'll probably re-read the review and try to adress what I can this week. Still annoys me to use pywikibot when I don't need to just to get few simple wikibase API results :)

[danmichaelo]

Cool! I'll try to respond quickly if you post something. If you want to discuss anything more in detail, we could also do a Gitter chat.

[PierreSelim]

@danmichaelo right now I'm rebasing and squashing for readability purpose :)

[AdamWill]

hey again! @waldyrious looped me into helping out with maintaining mwclient since dan is inactive ATM. I'm looking through old pull requests, obviously this one is pretty large and will take a minute to get familiar with, but if you're still interested, could you look at rebasing it? One thing I'd definitely personally want to request to merge this: tests! I'd hate to merge a major new feature with no tests. Do you think you could write some? Thanks again!