Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inheritance issue in __repr__() methods #308

Merged
merged 1 commit into from Sep 24, 2023
Merged

Fix inheritance issue in __repr__() methods #308

merged 1 commit into from Sep 24, 2023

Conversation

NguoiDungKhongDinhDanh
Copy link
Contributor

@NguoiDungKhongDinhDanh NguoiDungKhongDinhDanh commented Sep 6, 2023 •
edited

Fixes #309.

@marcfrederick
Copy link
Member

Looks good to me. I think this technically breaks backwards compatibility as the __repr__ of sub-classes changes, though that should be pretty much irrelevant.

If none of the other maintainers are opposed then I'll merge this in a few days.

@AdamWill
Copy link
Member

LGTM too. I'm willing to take the bet that this won't break anyone in the real world...we should definitely mention it in the notes for the next release, though.

@marcfrederick marcfrederick merged commit 561d3d5 into mwclient:master Sep 24, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking change enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hardcoded class names in __repr__() methods
3 participants
@NguoiDungKhongDinhDanh @marcfrederick @AdamWill