Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(playback-core, mux-video, mux-player): addChapters interface #909

Merged
merged 31 commits into from May 21, 2024
Merged

feat(playback-core, mux-video, mux-player): addChapters interface #909

merged 31 commits into from May 21, 2024

Conversation

AdamJaggard
Copy link
Contributor

@AdamJaggard AdamJaggard commented Apr 23, 2024 •
edited

  • Adds a new interface for working with chapters: .addChapters(), .activeChapter, .chapters.
  • Amends cuepoints interface to match chapters and use a shared CueLike shape, with a startTime and optional endTime. The old shape of {time: number, value: T} is still supported for backwards compatibility. Because of this both CuePoints and Chapters support sparse (with gaps) or being joined up end to end
  • Chapters unsupported on Live content for this iteration, docs will mention this
  • Audio UI works as expected
image image

@vercel Vercel
Copy link

vercel bot commented Apr 23, 2024

@AdamJaggard is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

@vercel Vercel
Copy link

vercel bot commented Apr 23, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
elements-demo-create-react-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 4:09pm
elements-demo-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 4:09pm
elements-demo-svelte-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 4:09pm
elements-demo-vanilla ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 4:09pm
elements-demo-vue ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 4:09pm

@AdamJaggard AdamJaggard marked this pull request as ready for review April 25, 2024 15:25
@AdamJaggard AdamJaggard requested a review from a team as a code owner April 25, 2024 15:25
cjpillsbury
cjpillsbury approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@cjpillsbury cjpillsbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📖 😎

luwes
luwes approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@luwes luwes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@AdamJaggard AdamJaggard merged commit 84392f1 into muxinc:main May 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luwes luwes luwes approved these changes

@cjpillsbury cjpillsbury cjpillsbury approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AdamJaggard @luwes @cjpillsbury