MPTCP: implementation of mptcp #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is a test implementatation of mptcp fot the http context of the nginx server
matttbe
reviewed
Mar 15, 2024
src/core/ngx_connection.c
Outdated
| @@ -487,8 +488,12 @@ ngx_open_listening_sockets(ngx_cycle_t *cycle) | |||
| continue; | |||
| } | |||
|
|
|||
| #if (NGX_HAVE_MPTCP) | |||
| s = ngx_socket(ls[i].sockaddr->sa_family, ls[i].type, | |||
| ls[i].protocol); | |||
There was a problem hiding this comment.
is it ok now? not quite sure
matttbe
reviewed
Mar 15, 2024
this is a test implementatation of mptcp fot the http context of the nginx server fix: replace socket call swap w/ fallback fix: alignment, hopefully fix: removed compilator mptcp test add: an option mptcp for streams fix: spacing fix: removed useless pre-processors fix: value already zero
|
my bad, branch is back |
I guess you need to re-open the PR, or create a new one. |
|
still not proficient with git. i created a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is internal, and aims to implement MPTCP (defined in RFC8684) into the nginx socket creation process.
The current approach is to add an option to the
listendirective (namelymptcp) to enable and disable the protocol.It would be interesting to have it set by the
httporserverblocks but I don't currently see a good way of doing so.In this initial commit MPTCP is disabled by default simply because it is easy to implement, but it is preferable to have is on by default and give the option to user to explicitly disable it.