Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema: make all members of att.controlEvent also part of att.color #1457

Merged
merged 7 commits into from
May 31, 2024

Conversation

rettinghaus
Copy link
Member

@rettinghaus rettinghaus commented Apr 25, 2024

As discussed in #1086, all control elements should have @color available.

This affects

  • attacca
  • dir
  • dynam
  • f
  • fing
  • fingGrp
  • harm
  • metaMark
  • repeatMark

Closes #1086.
Closes #1454.

@github-actions github-actions bot added the Component: Core Schema changes to source/modules/* (assigned automatically) label Apr 25, 2024
@rettinghaus rettinghaus changed the title Make all members of att.controlEvent also part of att.color schema: make all members of att.controlEvent also part of att.color Apr 25, 2024
bwbohl
bwbohl previously approved these changes Apr 30, 2024
@bwbohl bwbohl added this to the MEI 5.x milestone Apr 30, 2024
@musicEnfanthen
Copy link
Member

Thank you @rettinghaus. Just a little sorting propsal above.

While you are at it, maybe you can have a look at the order of att.trill.vis memberships, too? It is not changed in this PR because it already had the att.color membership, but as it is also one of the members of att.controlevent, it may be reasonable to fix it along the way.

I also realized that <attaca>, <beamSpan>, and <tupletSpan> are the only controlevents without direct att.color class now. While the two span elements inherit it via their membership in att.beam.vis and att.tuplet.vis, it seems that <attaca> is simply missing it?

Co-authored-by: Stefan Münnich <stefan.muennich@unibas.ch>
@github-actions github-actions bot added the Component: Customizations changes to customizations/**/* (assigned automatically) label May 26, 2024
@rettinghaus
Copy link
Member Author

@musicEnfanthen Thanks for pointing out attacca. I made it also member of att.color and integrated now #1455, so everything is in one place.

Additionally I did some more spring cleaning with the sorting.

@musicEnfanthen musicEnfanthen merged commit a75d838 into music-encoding:develop May 31, 2024
3 checks passed
@rettinghaus rettinghaus deleted the feat/color branch May 31, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Core Schema changes to source/modules/* (assigned automatically) Component: Customizations changes to customizations/**/* (assigned automatically)
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Not possible to color repeatMark dynam not a member of att.color
4 participants