Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing outdated MusicXML files from LilyPond #22750

Merged
merged 3 commits into from May 17, 2024

Conversation

rettinghaus
Copy link
Contributor

I was wondering what should happen with the lilyXml in directory in test? It seems rather outdated and unused. I ran the script with LilyPond 2.24.3 and MuseScore 4.2.1 updating all the PNGs.

I'm in favor of just removing it completely, but if it must stay, it should at least be updated to the more recent files from https://github.com/cuthbertLab/musicxmlTestSuite.

@cbjeukendrup
Copy link
Contributor

I believe this folder is currently completely unused, so we can just as well remove it.
We could in theory add these files to the VTests, but that would be questionable for two reasons:

  • that would be testing two things at the same time, namely xml import and layout
  • it's unclear how much added value it would have, on top of the existing musicXML "unit tests"

What do you think about this?
And what do @oktophonie and @miiizen think about utilising this musicXML test dataset?

@rettinghaus
Copy link
Contributor Author

I think the tests we have for MusicXML support are tailored to specific functions of import or export, whereas the LilyPond test suite addresses more general functions of MusicXML itself. I don't see any added value in them.

@cbjeukendrup
Copy link
Contributor

In that case I'm also in favour of removing the thing. Less unused old files = less opportunities for confusion :)

@rettinghaus
Copy link
Contributor Author

@cbjeukendrup The whole directory has been removed now.

@rettinghaus rettinghaus changed the title Updating MusicXML files from LilyPond Removing outdated MusicXML files from LilyPond May 17, 2024
@miiizen
Copy link
Contributor

miiizen commented May 17, 2024

Yes, I agree! I don't see the need for any more XML tests.

@cbjeukendrup cbjeukendrup merged commit 02090ef into musescore:master May 17, 2024
10 of 11 checks passed
@rettinghaus rettinghaus deleted the xmltestsuite branch May 17, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants