Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #22696: Number inherits tuplet color #22699

Merged
merged 1 commit into from May 21, 2024

Conversation

XiaoMigros
Copy link
Contributor

Resolves: #22696

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@XiaoMigros XiaoMigros changed the title Fix #22696 Number inherits tuplet color Fix #22696: Number inherits tuplet color May 6, 2024
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 6, 2024
@bkunda bkunda requested review from zacjansheski and Eism May 7, 2024 13:08
@zacjansheski
Copy link
Contributor

Number reverts back to black on save and reopen

video1936599249.mp4

@XiaoMigros XiaoMigros force-pushed the tuplet-num-color branch 2 times, most recently from e303077 to f8473c8 Compare May 19, 2024 20:30
@XiaoMigros
Copy link
Contributor Author

Should be resolved now!

@RomanPudashkin RomanPudashkin merged commit 05306e8 into musescore:master May 21, 2024
11 checks passed
@RomanPudashkin RomanPudashkin removed the request for review from Eism May 21, 2024 14:19
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 22, 2024
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 22, 2024
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to change color for triplet
3 participants