Revert "Set PopupView as parent of PopupWindow_QQuickView" #22681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2fa36e3. That commit did fix a real problem (and a memory leak), but that problem should not occur anymore because of d18f9b3, and the commit caused other problems that are not quite trivial (musescore#22640 and musescore#22641). Therefore, we'll revert this commit for now.
Eism
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 2fa36e3. That commit did fix a real problem (and a memory leak), but that problem should not occur anymore because of d18f9b3, and the commit caused other problems that are not quite trivial (#22640 and #22641). Therefore, we'll revert this commit for now.
Resolves: #22640
Resolves: #22641
Ports #22644 to master