Issue #21263 allow typing dynamics from keyboard #22607
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <key>add-piano</key> | ||
| <seq>Alt+Shift+P</seq> | ||
| </SC> | ||
| <SC> |
There was a problem hiding this comment.
These 2-key shortcuts should work too:
<SC>
<key>add-pianissimo</key>
<seq>Alt+Shift+P,Alt+Shift+P</seq>
</SC>
<SC>
<SC>
<key>add-mezzo-piano</key>
<seq>Alt+Shift+M,Alt+Shift+P</seq>
</SC>
<SC>
<SC>
<key>add-mezzo-forte</key>
<seq>Alt+Shift+M,Alt+Shift+F</seq>
</SC>
<SC>
<SC>
<key>add-fortissimo</key>
<seq>Alt+Shift+F,Alt+Shift+F</seq>
</SC>with corresponding commands in the code of course
| @@ -25,6 +25,7 @@ | |||
| #include "async/notification.h" | |||
| #include "notationtypes.h" | |||
| #include "types/retval.h" | |||
| #include "engraving\types\types.h" | |||
There was a problem hiding this comment.
Causes build faliures
There was a problem hiding this comment.
The correct way would be
Suggested change
| #include "engraving\types\types.h" | |
| #include "engraving/types/types.h" |
but it looks like you don't need this #include at all, because you use the typedef from notationtypes.h.
cbjeukendrup
requested changes
May 4, 2024
|
|
||
| //undoAddElement(dy); | ||
|
|
||
| Articulation* na = Factory::createArticulation(this->dummy()->chord()); |
There was a problem hiding this comment.
It seems that you are abusing Articulations to show dynamics. Why not use the Dynamic class?
| @@ -25,6 +25,7 @@ | |||
| #include "async/notification.h" | |||
| #include "notationtypes.h" | |||
| #include "types/retval.h" | |||
| #include "engraving\types\types.h" | |||
There was a problem hiding this comment.
The correct way would be
Suggested change
| #include "engraving\types\types.h" | |
| #include "engraving/types/types.h" |
but it looks like you don't need this #include at all, because you use the typedef from notationtypes.h.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #21263
In the future I plan to implement this feature exactly as requested. However, I could not implement adding dynamics through text because of limited time and limited understanding. Instead I added support for adding a piano dynamic and adding a forte dynamic with Shift+Alt+P and Shift+Alt+F, respectively