Set correct stem direction on pasting notes on a drum stave #22575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 25, 2024
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 25, 2024
|
@zacjansheski sorted - though found a crash unrelated to this PR when performing the steps in #22712 in voice 2 which remains unfixed as yet. |
|
I've included a fix for that crash |
zacjansheski
approved these changes
May 13, 2024
RomanPudashkin
approved these changes
May 14, 2024
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 14, 2024
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 14, 2024
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 14, 2024
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 14, 2024
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 14, 2024
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 14, 2024
Backport of musescore#22575 Plus some includes cleanup Plus an entirely unrelated debug message fix
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 14, 2024
Backport of musescore#22575 Plus some includes cleanup Plus an entirely unrelated debug message fix
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 14, 2024
Backport of musescore#22575 Plus some includes cleanup Plus an entirely unrelated debug message fix
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 14, 2024
Backport of musescore#22575 Plus some includes cleanup Plus an entirely unrelated debug message fix
This was referenced May 24, 2024
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #22313
Resolves: #22712
Resolves: Crash on changing a note or rest length in any voice other than 1 which results in a tied duration over a barline
This PR sets a chord's stem direction correctly based on the note which is being pasted on a drum stave
Screen.Recording.2024-04-25.at.15.12.26.mov