Prevent overlapping fingering text on cross stave beams #22566
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miiizen
force-pushed
the
22419-fingering-text
branch
from
a0b3c0b
to
adc693d
Compare
oktophonie
approved these changes
Apr 26, 2024
miiizen
force-pushed
the
22419-fingering-text
branch
from
adc693d
to
97fadae
Compare
mike-spa
reviewed
May 23, 2024
| } | ||
| } | ||
| } | ||
| } | ||
| for (const staff_idx_t staffIdx : shapesToRecreate) { | ||
| segment->createShape(staffIdx); |
There was a problem hiding this comment.
This looks good! Why is it necessary to recreate the segment shape though?
There was a problem hiding this comment.
Oops, correct - we don't!
miiizen
force-pushed
the
22419-fingering-text
branch
from
97fadae
to
a474fde
Compare
miiizen
force-pushed
the
22419-fingering-text
branch
from
a474fde
to
6581616
Compare
mike-spa
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #22419