Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #21923 correct microtonal accidentals in transposing instruments #22512

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sammik
Copy link
Contributor

@sammik sammik commented Apr 21, 2024

Resolves: #21923

TODO

  • handle special cases (when new accidental is out of range /microtonal X# to XX/)
  • verify trnaspositions
  • fix octave jumps on arrow up (b-c)
  • create utests
  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@sammik sammik marked this pull request as draft April 21, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Microtonal accidentals behave incorrectly with transposing instruments
1 participant