Fix #21900: Note highlighting on the piano keyboard ignores ottava.

[davidfaianunes]

Resolves: #21900

Bug: The pianokeyboard view was not taking into account the ottavas, so if you put an ottava on the score you would hear the pitched-up note, but the note you would see on the keyboard view would not be pitched-up by an octave as well.

Solution: In the class Note there are multiple computations for pitch, for different purposes. I've used the playback pitch (ppitch) instead of the effective pitch (epitch) on the pianokeyboardcontroller.cpp, because the playback audio was using the pitch I wanted shown on the keyboard.

Tested on Windows.

• I signed the CLA
• The title of the PR describes the problem it addresses
• Each commit's message describes its purpose and effects, and references the issue it resolves
• If changes are extensive, there is a sequence of easily reviewable commits
• The code in the PR follows the coding rules
• There are no unnecessary changes
• The code compiles and runs on my machine, preferably after each commit individually
• I created a unit test or vtest to verify the changes I made (if applicable)

[zacjansheski]

I want to make sure this is desirable behavior for transposing instruments. (I honestly don't know, I suppose if it bothers someone they can switch to concert pitch...)

@bkunda @cbjeukendrup

video1603335705.mp4

[cbjeukendrup]

Hm... that looks a bit janky. This reminds me of #15594. We might want to introduce a toggle to switch the keyboard behaviour between "notated pitch" and "sounding pitch".