multirom: Fix /data/media/0 media linkage for SDCardFS #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* In a MultiROM environment, /data is owned by the
booted secondary ROM, specifically it can even be
part of an external MicroSD (for example with EXT4)
* By using a ROM supporting SDCardFS, the interal
media storage will be accessed through its driver,
but the fact /data/media/0 could be used under
specific conditions means the /data/media mounts
used by the emulated storage loop through:
- /data/media (external ROM)
- /data/media/0 (internal storage)
* SDCardFS prevents "cross-device" linkage by
returning -EXDEV, breaking internal storage access
* Always use the proper /data/media path on newer APIs
to avoid any cross-device linkage of internal storage,
and preserve old handling up to API 22 (Android 5.1)
Change-Id: Ib49db68eede289d3943b9537d542eef5082e3118
Signed-off-by: Adrian DC <radian.dc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a MultiROM environment, /data is owned by the
booted secondary ROM, specifically it can even be
part of an external MicroSD (for example with EXT4)
By using a ROM supporting SDCardFS, the interal
media storage will be accessed through its driver,
but the fact /data/media/0 could be used under
specific conditions means the /data/media mounts
used by the emulated storage loop through:
SDCardFS prevents "cross-device" linkage by
returning -EXDEV, breaking internal storage access
Always use the proper /data/media path on newer APIs
to avoid any cross-device linkage of internal storage,
and preserve old handling up to API 22 (Android 5.1)
Change-Id: Ib49db68eede289d3943b9537d542eef5082e3118
Signed-off-by: Adrian DC radian.dc@gmail.com