Periodically synchronize kernel state #141
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjmartineau
reviewed
Jun 5, 2021
configure.ac
Outdated
| @@ -120,6 +120,10 @@ AC_ARG_WITH([path-manager], | |||
|
|
|||
| AC_SUBST([mptcpd_default_pm],[$with_path_manager]) | |||
|
|
|||
| dnl Default kernel sync interval in seconds. | |||
| default_sync_interval=5 | |||
There was a problem hiding this comment.
This seems fast to me. Maybe 60 seconds? (I'm not super attached to that number, just trying to think of a less aggressive rate)
There was a problem hiding this comment.
Good point. Bumped to 60 seconds in 4f1b183.
src/path_manager.c
Outdated
| Periodically synchronize kernel state with mptcpd, such as | ||
| address IDs managed by the in-kernel path manager. | ||
| */ | ||
| pm->sync_timeout = |
There was a problem hiding this comment.
What do you think about using sync_interval == 0 to turn off polling?
That seems to be what happens with l_timeout_create() is given a 0 time value anyway, but it goes ahead and sets up the timerfd and ELL watch anyway. Could skip that work if the sync interval is 0.
There was a problem hiding this comment.
I agree. Implemented in 69b1e6e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.