Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for LLVM 17 #1045

Merged
merged 3 commits into from
May 16, 2024
Merged

Add support for LLVM 17 #1045

merged 3 commits into from
May 16, 2024

Conversation

rjaegers
Copy link
Contributor

This PR adds support to build Mull with LLVM 17.

I have not yet updated any documentation or ci infrastructure. Please see if this can be incorporated into Mull, if any further modifications are required I can do so. This PR supports our devcontainer use-case.

@rjaegers rjaegers changed the title chore: add support for llvm 17 Add support for LLVM 17 Apr 29, 2024
Copy link
Member

@AlexDenisov AlexDenisov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for submitting this PR, highly appreciated!

@AlexDenisov
Copy link
Member

There are some failures unrelated to your changes, I think I need to update our ansible playbooks, I'll try to get to it by the end of this week.

@AlexDenisov
Copy link
Member

@rjaegers I fixed the CI issue, could you please update the PR against main? Happy to merge it as soon as CI is green!

@rjaegers
Copy link
Contributor Author

rjaegers commented May 16, 2024

@AlexDenisov updated with latest changes from main and fixed an issue I introduced with the tests for LLVM < 17. I think it should be good to go.

Happy to do something back for this awesome project!

@AlexDenisov AlexDenisov merged commit 63b7c10 into mull-project:main May 16, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants