[charts] Fix some bad practice with useSlotProps

[alexfauquette]

Follow up on #12921 comments

Each comment get its commit

The class should be passed to className instead of being inside additionalProps (several occurrences in the package)

@flaviendelangle about this last comment, I thought the goal of this hook is to do the merging, and so I could delegate it the fact of merging multiple className props.

This pattern of passing className to the additionalProps also exists in the pickers package. Is it a mistake?

https://github.com/mui/mui-x/blob/master/packages/x-date-pickers/src/internals/components/PickersArrowSwitcher/PickersArrowSwitcher.tsx/#L121-L134

[mui-bot]

Deploy preview: https://deploy-preview-13141--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 0439d02

[flaviendelangle]

This pattern of passing className to the additionalProps also exists in the pickers package. Is it a mistake?

Probably yes

---

@flaviendelangle about this last comment, I thought the goal of this hook is to do the merging, and so I could delegate it the fact of merging multiple className props.

Yes, that's also how I understand it's purpose.
To be fair, I can't think of any difference between passing the className to additionalProps vs to it's dedicated root param, other than consistency throughout the codebase.

[alexfauquette]

@JCQuintas I think this PR contains some code standards :)

[JCQuintas]

😆

[flaviendelangle]

This should work and allow you to not spread other below:

Suggested change

	externalSlotProps: slotProps?.bar,
	externalSlotProps: slotProps?.bar,
	externalForwardedProps: other,

It should also automatically merge the event handlers and stuff like ref and style

[LukasTy]

This is a nice suggestion! 👍
Other than that, the changes look great! 💯

[alexfauquette]

I've not done the other components, because the TS result seems buggy. even if other type contains d: string the resulting props do not contain it

[flaviendelangle]

The typing of useSlotProps is ... complex 😆

[JCQuintas]

@JCQuintas I think this PR contains some code standards :)

Will add a section about slots 😅

[LukasTy]

This is a nice suggestion! 👍
Other than that, the changes look great! 💯

[JCQuintas]

Btw, not sure who handles this, but it would be really helpful if these functions/types we use extensively had more comprehensive typedocs with how to use them and examples.

[flaviendelangle]

it would be really helpful if these functions/types we use extensively had more comprehensive typedocs with how to use them and examples.

There is nothing preventing us from opening a PR on the core to improve the JSDOC 👍

[JCQuintas]

it would be really helpful if these functions/types we use extensively had more comprehensive typedocs with how to use them and examples.

There is nothing preventing us from opening a PR on the core to improve the JSDOC 👍

I would if I knew how they worked 😆

[flaviendelangle]

Sure, I was not asking you to open the PR for something like useSlotProps right away 😆