[DataGrid] Escape formulas in CSV and Excel export #13115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to make adding new options easier
cherniavskii
added
the
component: data grid
|
Deploy preview: https://deploy-preview-13115--material-ui-x.netlify.app/ Updated pages: |
cherniavskii
added
security
cherniavskii
commented
May 16, 2024
| /** | ||
| * If `true`, the formulas in the cells will be escaped. | ||
| * It is recommended to set this to `true` for security reasons. | ||
| * @default false |
There was a problem hiding this comment.
@mui/xgrid What do you think about making it true by default?
Technically, it's a breaking change, but it's also a security fix.
Any objections?
There was a problem hiding this comment.
No objection, we should change it.
romgrk
reviewed
May 17, 2024
| * It is recommended to set this to `true` for security reasons. | ||
| * @default false | ||
| */ | ||
| escapeFormulae?: boolean; |
There was a problem hiding this comment.
escapeFormulas? From what I can read online formulas seems to be the most popular plural for formula.
There was a problem hiding this comment.
I followed the same naming that exceljs used:
But I actually prefer escapeFormulas, I'll update 👍🏻
romgrk
approved these changes
May 17, 2024
michelengelen
approved these changes
May 17, 2024
cherniavskii
added a commit
to cherniavskii/mui-x
that referenced
this pull request
May 20, 2024
cherniavskii
added a commit
that referenced
this pull request
May 22, 2024
arthurbalduini
pushed a commit
to arthurbalduini/mui-x
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11702