Inline bits of pdf crate for better performance #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorpic
changed the title
jorpic
force-pushed
the
inline-pdf-storage
branch
from
16d7e62
to
1159c80
Compare
jorpic
commented
Apr 30, 2024
|
|
||
| match res { | ||
| Ok(storage) => Ok(Self(storage)), | ||
| Err(err) => Err(anyhow!(err).context("Failed to init cracker")), |
There was a problem hiding this comment.
Not sure if it worth bringing anyhow here or it is better to create a custom error with thiserror.
jorpic
commented
Apr 30, 2024
| use pdf::PdfError; | ||
| use pdf::any::AnySync; | ||
| use pdf::file::{Cache, Storage}; | ||
| use pdf::object::{ParseOptions, PlainRef}; | ||
|
|
||
| #[derive(Clone)] | ||
| pub struct PDFCracker(Vec<u8>); |
There was a problem hiding this comment.
After the change, PDFCracker is just a wrapper around Vec<u8> without any additional functionality. It could be better to rename it to PDFFile or something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello and thank you for this project, it helped me A LOT recently.
I was in a need to restore passwords for multiple PDF documents, so performance was really important. It occurs that sharing single
pdf::file::Storagebetween attempts in a single thread results in a noticeable speedup.Cracking one of the example files on my machine:
Single thread
Four threads