Avoid installation if included as a subproject #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C++20 removed the deprecated std::result_of in favor of std::invoke_result. Switch between usage of those depending on the cpp_lib_is_invocable feature test macro. See: - https://en.cppreference.com/w/cpp/types/result_of - https://en.cppreference.com/w/cpp/feature_test#Library_features
Fix build for C++20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
clippis included as a subproject withadd_subdirectory, the target is installed alongside the other targets of the main project. This is not always advisable, especially not if the main project installs an executable (so the headers file are not needed for users of the main target).This PR provides a variable that the user can set to enable the install target. The variable is set by default on
ONorOFFdepending on whether the project is being built as a subproject or not.A potential problem might arise for compatibility with existing clients that implicitly relied on the current behavior. They would have to explicitly set the
CLIPP_INSTALLvariable toON. If this breaking change has to be avoided, another acceptable solution would be to simply set the variable toONby default and at least let the client disable it if needed.