Merge pull request #77 from nicoschoenmaker/feature/link-display

Shorten output when link target and display match
mtibben · May 15, 2017 · bf613dc · bf613dc
2 parents c6490bd + 7c8a3c2
commit bf613dc
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/src/Html2Text.php b/src/Html2Text.php
@@ -434,10 +434,16 @@ protected function buildlinkList($link, $display, $linkOverride = null)
 
             return $display . ' [' . ($index + 1) . ']';
         } elseif ($linkMethod == 'nextline') {
+            if ($url === $display) {
+                return $display;
+            }
             return $display . "\n[" . $url . ']';
         } elseif ($linkMethod == 'bbcode') {
             return sprintf('[url=%s]%s[/url]', $url, $display);
         } else { // link_method defaults to inline
+            if ($url === $display) {
+                return $display;
+            }
             return $display . ' [' . $url . ']';
         }
     }

diff --git a/test/LinkTest.php b/test/LinkTest.php
@@ -145,4 +145,18 @@ public function testDoLinksBBCode()
 
         $this->assertEquals($expected, $html2text->getText());
     }
+
+    public function testDoLinksWhenTargetInText()
+    {
+        $html = '<a href="http://example.com">http://example.com</a>';
+        $expected = 'http://example.com';
+
+        $html2text = new Html2Text($html, array('do_links' => 'inline'));
+
+        $this->assertEquals($expected, $html2text->getText());
+
+        $html2text = new Html2Text($html, array('do_links' => 'nextline'));
+
+        $this->assertEquals($expected, $html2text->getText());
+    }
 }