Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filesystem: Use working directory only if it is applicable #4412

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

orgads
Copy link
Contributor

@orgads orgads commented Feb 12, 2024

Check for both msys-2.0.dll and bash.exe. Otherwise, use the script directory. Some applications install msys2 runtime as a dependency, while it is not a full msys environment.

Check for both msys-2.0.dll and bash.exe. Otherwise, use the script
directory. Some applications install msys2 runtime as a dependency,
while it is not a full msys environment.
@Biswa96
Copy link
Member

Biswa96 commented Feb 12, 2024

What issue does this fix?

@orgads
Copy link
Contributor Author

orgads commented Feb 12, 2024

I tried to state it in the commit message. I guess it was not enough.

When I run C:/msys64/msys2_shell.cmd -mingw64 -defterm -no-start from a directory that has msys-2.0.dll, but doesn't have bash.exe, it fails with this error:

'"F:\Utils\\bash"' is not recognized as an internal or external command,
operable program or batch file.

@Biswa96
Copy link
Member

Biswa96 commented Feb 12, 2024

What does the directory have? What do you want to do with the msys2_shell.cmd if that directory does not have any shell?

@orgads
Copy link
Contributor Author

orgads commented Feb 12, 2024

I just want to start a shell, and I happened to run from this directory.

It has a utility that is built with msys, so I need the msys runtime there.

@orgads
Copy link
Contributor Author

orgads commented Feb 14, 2024

What's the verdict?

@orgads
Copy link
Contributor Author

orgads commented Mar 2, 2024

@Biswa96?

@Biswa96
Copy link
Member

Biswa96 commented Mar 2, 2024

I can not understand the situation clearly. Please wait for other to comment 🙏

@orgads
Copy link
Contributor Author

orgads commented Mar 2, 2024

I'll try to explain with an example:

  • Build sipp with msys
  • Copy sipp.exe and all its DLL dependencies (including msys-2.0.dll) to C:\sipp
  • cd /d C:\sipp
  • Run C:\msys64\msys2_shell.cmd -defterm -no-start
C:\sipp>C:\msys64\msys2_shell.cmd -defterm -no-start
'"C:\sipp\\bash"' is not recognized as an internal or external command,
operable program or batch file.

@orgads
Copy link
Contributor Author

orgads commented Mar 11, 2024

ping? @Biswa96 / @lazka

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants