Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --af_esp flag as it's deprecated #324

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bozbezbozzel
Copy link

This flag stops vcf2maf from running with vep 107 (haven't tested it for earlier versions)

This flag stops vcf2maf from running with vep 107 (haven't tested it for earlier versions)
Remove --af_esp flag as it's deprecated
@ckandoth
Copy link
Collaborator

ckandoth commented Nov 7, 2022

Thanks for this. Unfortunately, vcf2maf's output became the standard MAF format that includes two columns for these ESP allele frequencies. So, we'll leave the columns in, but it will never have data in the rows.

The only think pending is to remove the ESP data from the test dataset, so that the Travis CI tests can pass. I'd appreciate if you can add this to the PR. If not, the earliest I can get to it is January.

@ckandoth ckandoth self-assigned this Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants