Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow half-open TLS connections #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/index.js
Expand Up @@ -64,6 +64,8 @@ if (isOldNode) {
if (firstByte < 32 || firstByte >= 127) {
// tls/ssl
socket.ondata = null;
// TLS sockets don't allow half open
socket.allowHalfOpen = false;
self._tlsHandler(socket);
socket.push(d.slice(start, end));
} else {
Expand Down Expand Up @@ -91,6 +93,8 @@ if (isOldNode) {
socket.unshift(data);
if (firstByte < 32 || firstByte >= 127) {
// tls/ssl
// TLS sockets don't allow half open
socket.allowHalfOpen = false;
this._tlsHandler(socket);
} else
this.__httpSocketHandler(socket);
Expand Down