Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the c_cpp_properties.json configuration overwrite issue (#818) #1287

Merged
merged 2 commits into from
Apr 27, 2024

Conversation

BrunoB81HK
Copy link

This change fix #818. It changes only the configurations that are not already set.

One thing that was not changed is the default C++ standard being at C++14.

@BrunoB81HK BrunoB81HK requested a review from a team as a code owner April 11, 2024 15:17
Copy link
Member

@ooeygui ooeygui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!
Change looks good.
(I'll create an issue to update the cpp standard based on distro)

@BrunoB81HK
Copy link
Author

@microsoft-github-policy-service agree

@BrunoB81HK
Copy link
Author

Thanks a lot @ooeygui! Let me know if you need anything!

@ooeygui ooeygui merged commit 03591b4 into ms-iot:master Apr 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] C/C++ standards overridden and invalid for newer ROS2
3 participants