Search module bug fix #378
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ould cause it to stop working. Now it defaults to the "oldest" (smallest id number).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for bug where removing the first website from the search module would cause it to stop working.
Now it defaults to the "oldest" (smallest id number).
Reason:
It used to be that the search module by default tried to find the website with id = 1 however if a user deletes their first website the db would not shift the other ones back to 1 causing it to crash. Now it defaults to id closest to 1 (smallest out of all of them).
I also added a small log entry when failing to grab the newznab entry from the db.