Return HTTP response even on non-2XX responses. Clients might want it. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrjones
added a commit
that referenced
this pull request
Sep 4, 2013
Return HTTP response even on non-2XX responses. Clients might want it.
|
Thanks!! |
|
You're welcome! Thanks for the library. And sorry for the two issues instead of one. I've run into some other issues with using this function and those that return its result, and I'm not sure how they should be addressed. (Let me know if you want this as a separate issue.) Specifically, clients can't determine whether the call failed due to network error or because of something application-level (like non-2XX response). So far it seems necessary to do a substring match for "HTTP response is not 200/OK as expected" to determine that the call failed due to a server response. Any suggestions? |
|
( FYI: Moved this to a new issue. See the discussion in #11 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #8