Changing text color feature #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Mir3605, Thanks a million for your contribution! Could you please provide an example in the sample app too? and would be nice if you could provide a screenshot of weird behavior with non-white layouts as you mentioned! Thanks in advance! |
|
Hi @mreram ! Sure! I added a sample of these functionalities to the sample app. Strangely, I cannot repeat the bug with weird behavior in a non-white background. However, it was identical to the issue 42: #42 I have also updated the readme file with new coloring functionalities. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the possibility to change both title text and message text color. I also changed the color of the background of GuideMessageView to transparent, as it caused weird behavior with non-white layouts.