allow for horizontal callouts using gravity sideAuto and sideCenter #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mreram
reviewed
Aug 18, 2022
|
|
||
| private float startXLineAndCircle; |
mreram
reviewed
Aug 18, 2022
| private float startYLineAndCircle; | ||
| private float circleIndicatorSize = 0; | ||
| private float circleIndicatorSizeFinal; | ||
| private float circleInnerIndicatorSize = 0; | ||
| private float lineIndicatorWidthSize; | ||
| private float lineIndicatorHeightSize; |
mreram
reviewed
Aug 18, 2022
| @@ -273,24 +287,48 @@ protected void onDraw(final Canvas canvas) { | |||
| paintCircleInner.setColor(CIRCLE_INNER_INDICATOR_COLOR); | |||
| paintCircleInner.setAntiAlias(true); | |||
|
|
|||
| final float x = (targetRect.left / 2 + targetRect.right / 2); | |||
| float x = 0.0f; | |||
There was a problem hiding this comment.
This variable name is too general, x of what? please clarify it and choose a better name.
mreram
reviewed
Aug 18, 2022
Comment on lines
23
to
26
| android:layout_width="0dp" | ||
| android:layout_height="wrap_content" | ||
| android:layout_gravity="left" | ||
| android:layout_marginLeft="20dp" | ||
| android:layout_marginRight="10dp" | ||
| android:maxWidth="0dp" |
There was a problem hiding this comment.
It made invisible this image view, please revert these changes
mreram
requested changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two gravity values: sideAuto and sideCenter that make the callout appear right or left of the selected view