Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix warning in ios 10 #136

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix warning in ios 10 #136

wants to merge 1 commit into from

Conversation

dimohamdy
Copy link

@dimohamdy
fix warning of
ffa21e6 
Assigning to 'id<CAAnimationDelegate> _Nullable' from incompatible type 'MRCircularProgressView *const __strong'
@dimohamdy
Copy link
Author

@mrackwitz can you change travis config to new Xcode?

sirnacnud
sirnacnud suggested changes May 7, 2017
View reviewed changes
Copy link

@sirnacnud sirnacnud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CAAnimationDelegate should only be specified when building against iOS 10 SDK and greater.

You can use __IPHONE_OS_VERSION_MAX_ALLOWED to determine what SDK is being used during compilation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirnacnud sirnacnud sirnacnud requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dimohamdy @sirnacnud