Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use drawViewHierarchyinRect when applicable #109

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HighKo
Copy link

@HighKo HighKo commented Sep 11, 2015

This request has 2 purposes:

  1. Avoid crashes in iOS 9 when -renderInContext is called at this point
  2. Increase performance, when -drawViewHierarchyInRect is available

@mrackwitz
Copy link
Owner

This reverts this change here, which is sadly poorly documented. Overall this has a lot of edge cases and needs some manual testing on device with orientation changes and e.g. navigation controller animations. But if it is still currently crashing, than it is unlikely, that even if that would be a regression, it will be fixed soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants