Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing opacity of the background mask as well as hiding it #105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ferusinfo
Copy link

In the project that I am working on, I was required to hide - and in some cases change its opacity - the background mask that is displaying below the overlay.

This pull request is adding that funcionality to the main library.
Hope you can merge it and therefore we will be able to use the official repository instead of the fork.

Thanks! :)

@mrackwitz
Copy link
Owner

I'd propose to collapse the functionality into one single property dimmedBackgroundColor.

/**
The color used to dim the entire area of the superview when the overlay is shown.

The default value is translucent black with an opacity of 40%.

Set this property to `nil` to prevent a background color change when the overlay is shown.
*/
+@property (nonatomic, copy) UIColor *dimmedBackgroundColor UI_APPEARANCE_SELECTOR;

What do you think?

@ferusinfo
Copy link
Author

That is a good call - I haven't thought about this honestly 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants