Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debian: add some 'easy' dependencies #202

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

wsldankers
Copy link
Contributor

@wsldankers wsldankers commented Nov 20, 2022

Adds dependencies for SDL2, Wayland, libsixel, pipewire, all of which are available in both Debian stable and Ubuntu 22.04 LTS and 24.04 LTS.

Also enables DVB support (which doesn't have any dependencies) and bumps the debhelper compat version to something less archaic.

@Dudemanguy
Copy link
Member

Dudemanguy commented Aug 28, 2023

Old I know. I would have merged it but according to debian documentation:

The compat 11 is discouraged for new packages as it suffers from feature interaction between dh_installinit and dh_installsystemd causing services to not run correctly in some cases.

That probably doesn't apply to us but maybe we should pick a different number anyways. Not sure if 12 makes the most sense or something even newer. I'll leave that up to you.

Adds dependencies for SDL2, Wayland, libsixel, pipewire, all of which
are available in both Debian stable and Ubuntu 22.04 LTS and 24.04 LTS.

Also enables DVB support (which doesn't have any dependencies) and
bumps the debhelper compat version to something less archaic.
@wsldankers
Copy link
Contributor Author

Old I know. I would have merged it but according to debian documentation:

The compat 11 is discouraged for new packages as it suffers from feature interaction between dh_installinit and dh_installsystemd causing services to not run correctly in some cases.

That probably doesn't apply to us but maybe we should pick a different number anyways. Not sure if 12 makes the most sense or something even newer. I'll leave that up to you.

Yeah, those caveats definitely did not apply to this package. At the time, 11 was the highest version supported by the then-current debian/ubuntu releases I was targeting. Since those versions are now obsolete I changed it to 12 to avoid the discussion.

@Dudemanguy
Copy link
Member

Thanks, let's finally pull this in.

@Dudemanguy Dudemanguy merged commit 993fe7d into mpv-player:master Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants