Close button in toolbar UI for physically disabled persons (ticket #4328) #144
Conversation
|
Your indenting looks wrong |
|
I honestly don't really see how this can help physically disabled persons. I would think that it's easier for them to either use the hotkey or the usual close button in the title bar since it's common to all software. |
|
According to the instructions at Readme.md i've selected the easiest ticket number #4838 on the track and did the first part of it. I thought that if there is a ticket, then there must be a need for a close button. |
|
There are a lot of tickets on the tracker that haven't been assessed yet. The priority is fixed by the ticket opener and can then be changed by the team. The high priority here was set by the opener and nobody from the team had time to look at the ticket and decided on what to do with it. |
|
The ticket was aimed specifically at the fullscreen UI. There is indeed no button to go back to windowed mode without stopping the video. Rather than introducing a redundant close button, it would be better to introduce a fullscreen toggle button on the toolbar. @Underground78 We might want to prevent the ticket opener from setting the priority, it's unhelpful. I haven't seen a convenient way on trac to do this, but we can prevent it using a plugin. |
|
Maybe I can be helpfull with other real tasks? Especially with user interface? |
Seems easier to me to just double click anywhere on the screen in that case than aiming at a button in a possibly hidden toolbar. |
So is clicking anywhere to pause, but we have a button for that. We should have buttons for the very basic functionality of the player. Anyway, I don't think we should suddenly introduce a new button in an old interface, better to have it as part of a larger change. |
|
Won't this break things with current toolbar images we have on Trac? @Armada651: I agree with the priority change. |
Yes it would. |
|
I doubt we could get the toolbar creators to update their contrributions. I mean, we don't even have all of the contact details at all... Anyway, I guess if we decide to merge this, it should be in the next major version bump. And let's hope people will just update their toolbars. |
|
I agree with Armada651. For me it is very uncomfortable to enter the full size mode by double click: video stops playing after clicking. So the toggle button like in VMWare or Remote Desktop can be useful. To add the toggle button we need to change the toolbar image.
May be this feature from ticket can be helpful? Can I implement it? |
Hm, how about just pressing F11 (or any other user-defined key)? By the way, there are some physically or intellectually disabled people from which I sometimes get some feedback about the German translation. And as far as I know, all of them are able to get along just fine with the actual MPC-HC version. |
|
@LuanMax The problem arises when you are working on multiple screens. So one way to give mpc-hc focus back again is to click on the video and thus pause the video (the other would be to Alt-Tab through all open windows), then use ESC (lets say) to exit full screen. In my setup i use the middle button to enter/exit full screen, but most of the time that button is pretty sensitive and often i find my self skipping backwards/forwards to other videos in the folder... Personally i agree that a toolbar button would be very convenient way to enter/exit full screen. |
OK, thanks, I missed this scenario. |
I'd suggest that you maybe comment on ticket per se or talk with guys via IRC if you want faster response, being that we're a bit off topic here xD |
|
"Flybar" would probably solve the problem. It is perfect to hold toggle fullscreen button among other things. |
Fix vs2019 compile error
Hello,
I've added a close button in toolbar after the "step" button and before the "volume" button.
I've checked mph working on Windows XP Professional, Windows 7 x64 and Windows 10 Preview x86.
Hope everything is ok.
Ticket:: https://trac.mpc-hc.org/ticket/4328#no4