Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding test cases for the class DiffMotionDetector in the motion_dete… #107

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Umair0343
Copy link

…ction.py file

@Umair0343
Copy link
Author

Umair0343 commented Sep 30, 2023

Description:
This pull request addresses issue #77: "Add Unit Tests." I have added unit tests for the class DiffMotionDetector in the motion_detection.py file to improve test coverage and ensure the correctness of the code.

Changes Made:

  • Added file test.py containing the unit tests.
  • Added background.jpg and foreground.jpg files. These images are passed to the test cases as demo images.

Testing Done:

  • These test cases have been created, checked and verified using CodiumAI.

Related Issues:
Closes #77

@mpatacchiola
Copy link
Owner

Thank you for the proposal. The test file looks good but its location is not appropriate. You placed the test file and the images under the deepgaze folder, which contains the main library.

Please create a tests folder outside of the deepgaze one and include a sub-folder called test_diff_motion_detector. You can include the two images in the same folder. Call the test file test_diff_motion_detector.py. The overall structure should be:

|--deepgaze
|--doc
|--etc
|--examples
|--tests
|    ^--test_diff_motion_detector
|         ^-- test_diff_motion_detector.py
|         ^-- background.jpg
|         ^-- foreground.jpg

Let me know if this is clear and thank you for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants