Upgrade to Django 1.10.1 #129
Conversation
glogiotatidis
changed the title
glogiotatidis
force-pushed
the
django1101
branch
from
e0c5120
to
46a313b
Compare
|
This is currently blocked by django-session-csrf being incompatible with Django 1.10. There's an open pull request to fix that: mozilla/django-session-csrf#30 @peterbe maybe you can push things forward? |
|
I left some comments mozilla/django-session-csrf#30 but once that lands I can take care up updating pypi. Then we can proceed on this PR. |
|
@peterbe updated! |
| @@ -1,14 +1,16 @@ | |||
| from django.conf import settings | |||
| from django.conf.urls import include, url | |||
| from django.contrib import admin | |||
| from django.views.static import serve as static_serve | |||
There was a problem hiding this comment.
Why did it need to be aliased? What's wrong with just serve?
There was a problem hiding this comment.
I just find static_serve more descriptive
|
We might need to go back to django-session-csrf and work on this. But I just created a fresh new install based on this branch and it won't even start. The fault lies with django-session-csrf but we have to take responsibility of that. |
|
Let's hope @moggers87 finds the time to complete the python 3 support. I just can't accept that we say that sugardough is compatible with django 1.10 but doesn't work in Python 3. |
|
Fair enough, let's wait that for a week. @moggers87 is already working on py3 |
|
I tested your PR together with the python3 branch that @moggers87 is working on and now my recently created sugardough python 3.5 project worked. The only testing I did was to load the home page. But that didn't work before. So let's pause on this PR until we can also include a new django-session-csrf version hashed in. |
| --hash=sha256:44e4639ec057a6b6a9dddb869d4e3a4818fc9278ec490cce39aef08440592a93 | ||
| django-jinja==2.1.3 \ | ||
| --hash=sha256:64446ae1de3593136042147cb16ba9a3aa4449370d9c26c1ec9b7553b2d1c809 | ||
| django-session-csrf==0.7.0 \ |
There was a problem hiding this comment.
This now needs to be 0.7.1 and sugardough should be py3 ready. Yay!
glogiotatidis
force-pushed
the
django1101
branch
from
e4e720d
to
a54e187
Compare
|
woohoo! @peterbe updated, feel free to squash merge |
No description provided.