Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the sourcemaps ignorelist #481

Merged
merged 4 commits into from Apr 4, 2023
Merged

Conversation

bomsy
Copy link
Collaborator

@bomsy bomsy commented Mar 31, 2023

Add support for the x_google_ignoreList to the SourceMapConsumer.
Fixes #480

Add support for the x_google_ignoreList to the SourceMapConsumer.
@bomsy bomsy requested a review from ochameau March 31, 2023 23:37
@ochameau
Copy link
Contributor

ochameau commented Apr 3, 2023

It would be nice to mention any reference regarding this new field.
May be chromium original implementation changeset? Any public document describing this? Any discussion about this field on github...?
I found this doc for example.

Otherwise you are having linting issues reported by CI:
https://github.com/mozilla/source-map/actions/runs/4580007974/jobs/8088310426?pr=481

test/test-source-map-consumer.js Outdated Show resolved Hide resolved
@bomsy
Copy link
Collaborator Author

bomsy commented Apr 4, 2023

It would be nice to mention any reference regarding this new field. May be chromium original implementation changeset? Any public document describing this? Any discussion about this field on github...? I found this doc for example.

Oh yeah ...that's the spec link. So i updated the README documentation with the info. Since its in the sepc doument

@bomsy bomsy merged commit 6cc15e1 into mozilla:master Apr 4, 2023
10 checks passed
@hildjj
Copy link
Contributor

hildjj commented Apr 4, 2023

You added the .DS_Store file. That should probably be in .gitignore.

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request May 23, 2023
…tools-reviewers,nchevobbe

Also there is a patch to add support for ignoreList to the sourcemap library
mozilla/source-map#481

Differential Revision: https://phabricator.services.mozilla.com/D174357
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request May 23, 2023
…tools-reviewers,nchevobbe

Also there is a patch to add support for ignoreList to the sourcemap library
mozilla/source-map#481

Differential Revision: https://phabricator.services.mozilla.com/D174357
ErichDonGubler pushed a commit to ErichDonGubler/firefox that referenced this pull request May 26, 2023
…tools-reviewers,nchevobbe

Also there is a patch to add support for ignoreList to the sourcemap library
mozilla/source-map#481

Differential Revision: https://phabricator.services.mozilla.com/D174357
ErichDonGubler pushed a commit to ErichDonGubler/firefox that referenced this pull request May 26, 2023
…tools-reviewers,nchevobbe

Also there is a patch to add support for ignoreList to the sourcemap library
mozilla/source-map#481

Differential Revision: https://phabricator.services.mozilla.com/D174357
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request May 31, 2023
…tools-reviewers,nchevobbe

Also there is a patch to add support for ignoreList to the sourcemap library
mozilla/source-map#481

Differential Revision: https://phabricator.services.mozilla.com/D174357

UltraBlame original commit: b9d5882be65c92031cbabee86baac1a52e018246
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request May 31, 2023
…tools-reviewers,nchevobbe

Also there is a patch to add support for ignoreList to the sourcemap library
mozilla/source-map#481

Differential Revision: https://phabricator.services.mozilla.com/D174357

UltraBlame original commit: b9d5882be65c92031cbabee86baac1a52e018246
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request May 31, 2023
…tools-reviewers,nchevobbe

Also there is a patch to add support for ignoreList to the sourcemap library
mozilla/source-map#481

Differential Revision: https://phabricator.services.mozilla.com/D174357

UltraBlame original commit: b9d5882be65c92031cbabee86baac1a52e018246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for x_google_ignoreList extension to SourcemapConsumer
3 participants