Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dependency injection on the People and TeamManagers classes #2382

Merged
merged 4 commits into from
May 16, 2024
Merged

Support dependency injection on the People and TeamManagers classes #2382

merged 4 commits into from
May 16, 2024

Conversation

suhaibmujahid
Copy link
Member

This should simplify using the classes outside BugBot.

Checklist

  • Type annotations added to new functions
  • Docs added to functions touched in main classes
  • Dry-run produced the expected results
  • The to-be-announced tag added if this is worth announcing

@suhaibmujahid suhaibmujahid enabled auto-merge (rebase) May 3, 2024 16:04
benjaminmah
benjaminmah reviewed May 10, 2024
View reviewed changes
Copy link
Contributor

@benjaminmah benjaminmah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Suhaib,

Thank you for requesting my review for this PR. I've only suggested very minor changes (which are mostly optional and might not be required) and everything functionality-wise looks good to me!

bugbot/people.py Show resolved Hide resolved
tests/test_round_robin.py Outdated Show resolved Hide resolved
@suhaibmujahid @benjaminmah
Update tests/test_round_robin.py
31d2409 
Co-authored-by: Benjamin Mah <84874055+benjaminmah@users.noreply.github.com>
benjaminmah
benjaminmah approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@benjaminmah benjaminmah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @suhaibmujahid! LGTM!

@suhaibmujahid suhaibmujahid merged commit dbb37b9 into mozilla:master May 16, 2024
2 checks passed
@suhaibmujahid suhaibmujahid deleted the refactor-People-TeamManagers branch May 16, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminmah benjaminmah benjaminmah approved these changes

@Archaeopteryx Archaeopteryx Awaiting requested review from Archaeopteryx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@suhaibmujahid @benjaminmah