Refactor FXIOS-8361 Update mobile icons to new style pt4 #20140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-mobile-icons-to-new-style-pt4 # Conflicts: # firefox-ios/Client/Application/ImageIdentifiers.swift
…le-pt4 # Conflicts: # firefox-ios/Client.xcodeproj/project.pbxproj
…-mobile-icons-to-new-style-pt4 # Conflicts: # firefox-ios/Client.xcodeproj/project.pbxproj
Client.app: Coverage: 31.22
CredentialProvider.appex: Coverage: 18.76
ShareTo.appex: Coverage: 33.36
Generated by 🚫 Danger Swift against 2ce08f1 |
dataports
reviewed
May 6, 2024
| @@ -98,7 +98,7 @@ class ShareExtensionCoordinator: BaseCoordinator, | |||
| let themeColors = themeManager.currentTheme(for: windowUUID).colors | |||
| let colors = SendToDeviceHelper.Colors(defaultBackground: themeColors.layer1, | |||
| textColor: themeColors.textPrimary, | |||
| iconColor: themeColors.iconPrimary) | |||
| iconColor: themeColors.iconDisabled) | |||
There was a problem hiding this comment.
just checking - using the disabled color here was intentional yes?
There was a problem hiding this comment.
Yes, it's intentional. It was discussed with @cwzilla
dataports
reviewed
May 7, 2024
| @@ -529,7 +529,7 @@ extension LegacyTabTrayViewController: Notifiable { | |||
| else { return } | |||
| self?.countLabel.text = self?.viewModel.normalTabsCount | |||
| self?.segmentedControlIphone.setImage( | |||
| UIImage(named: ImageIdentifiers.navTabCounter)!.overlayWith(image: label), | |||
| UIImage(named: StandardImageIdentifiers.Large.tab)!.overlayWith(image: label), | |||
There was a problem hiding this comment.
Should we be force unwrapping the image here?
dataports
approved these changes
May 7, 2024
thatswinnie
had a problem deploying
to
github-pages
GitHub Actions
Failure
…-mobile-icons-to-new-style-pt4
|
@thatswinnie looks like the PR is reaching the warnings limit. That's why it is red.. |
thatswinnie
requested review from
jjSDET and
isabelrios
and removed request for
jjSDET
isabelrios
approved these changes
May 13, 2024
thatswinnie
deleted the
wt/FXIOS-8361-update-mobile-icons-to-new-style-pt4
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
It's been a long time coming: This is the last PR for our icon updates! Because of these updates we were able to remove 5 asset catalogs in total!
The PR updates:
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)