Skip to content

Commit

Permalink
Bugfix FXIOS-8891 Audio continues playing after Tab is closed #19777 (
Browse files Browse the repository at this point in the history
…#19802)

(cherry picked from commit 6e17168)

Co-authored-by: mattreaganmozilla <145381717+mattreaganmozilla@users.noreply.github.com>
  • Loading branch information
mergify[bot] and mattreaganmozilla committed Apr 15, 2024
1 parent 120bb70 commit a62a669
Showing 1 changed file with 6 additions and 6 deletions.
Expand Up @@ -2282,23 +2282,23 @@ extension BrowserViewController: LegacyTabDelegate {
theme: themeManager.currentTheme
)
tab.addContentScript(logins, name: LoginsHelper.name())
logins.foundFieldValues = { [weak self] field, currentRequestId in
logins.foundFieldValues = { [weak self, weak tab, weak webView] field, currentRequestId in
Task {
guard self?.autofillLoginNimbusFeatureFlag() == true else { return }
guard let tabURL = tab.url else { return }
guard let tabURL = tab?.url else { return }
let logins = (try? await self?.profile.logins.listLogins()) ?? []
let loginsForCurrentTab = logins.filter { login in
guard let recordHostnameURL = URL(string: login.hostname) else { return false }
return recordHostnameURL.baseDomain == tabURL.baseDomain
}
if !loginsForCurrentTab.isEmpty {
tab.webView?.accessoryView.reloadViewFor(.login)
tab.webView?.reloadInputViews()
tab?.webView?.accessoryView.reloadViewFor(.login)
tab?.webView?.reloadInputViews()
}
tab.webView?.accessoryView.savedLoginsClosure = {
tab?.webView?.accessoryView.savedLoginsClosure = {
Task { @MainActor [weak self] in
// Dismiss keyboard
webView.resignFirstResponder()
webView?.resignFirstResponder()
self?.authenticateSelectSavedLoginsClosureBottomSheet(
tabURL: tabURL,
currentRequestId: currentRequestId
Expand Down

1 comment on commit a62a669

@firefoxci-taskcluster
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh oh! Looks like an error! Details

InterpreterError at template.tasks[0].extra[0].treeherder[1].symbol: unknown context value cron

Please sign in to comment.