Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

Cn beta rxu #1080

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Cn beta rxu #1080

wants to merge 2 commits into from

Conversation

rxumoz
Copy link

@rxumoz rxumoz commented Nov 20, 2019

Fixes #1079

Testing and Review Notes

If a user is now set his/her phone as locale=zh_CN & language = Chinese, and the lockwise apk is not downloaded from Google play, there should be a way for the user to switch the service before login. After login, there should be no toggle button for switching service in settings.
Else there should be no "switch service" option, just like before.

Screenshots or Videos

图片 图片

To Do

  • The existed tests are all passed but I'm still working on the tests related to these new features

  • The default value of local service/global service is not really runtime. It is set during app firstrun; if change the locale and language setting later, the default value won't change with the new settings.

@rxumoz rxumoz requested a review from a team as a code owner November 20, 2019 03:19
@jhugman
Copy link
Contributor

jhugman commented Nov 20, 2019

This is really interesting. Thank you so much for your contribution.

I'd like to get @sandysage and @changecourse 's eyes on this.

@rxumoz rxumoz force-pushed the cn-beta-rxu branch 3 times, most recently from d5f5ea4 to eefbabc Compare November 21, 2019 06:58
@eliserichards
Copy link
Contributor

Hi @rxumoz! This is a great start, and I would love to collaborate more on this to get it ready to merge. That being said, we have limited bandwidth right now given the end-of-the-year rush. I would love to take a look at this again in January once we have some more engineering time to spare. Let me know what you think! 😄

@rxumoz
Copy link
Author

rxumoz commented Dec 2, 2019

Hi @rxumoz! This is a great start, and I would love to collaborate more on this to get it ready to merge. That being said, we have limited bandwidth right now given the end-of-the-year rush. I would love to take a look at this again in January once we have some more engineering time to spare. Let me know what you think! 😄

Hi, January is good for me. One thing I should mention is that I'm the only android engineer in Beijing office and Spring festival, which is the most important festival in China, is in the late January next year, so maybe it takes time for this feature.

@jhugman jhugman requested a review from a team December 3, 2019 14:46
@eliserichards
Copy link
Contributor

Cool! We'll make sure to work around the Spring Festival 😄 Thank you!

@jhugman jhugman removed the request for review from a team February 16, 2021 15:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add toggle button to allow users in China use local sync service
3 participants