Bug 1891527 - In Bugmail & Bug History for User Story edits, there's a warning about 'No newline at end of file' for user-entered values, even though the submitted value included a trailing newline #2234
Conversation
…a warning about 'No newline at end of file' for user-entered values, even though the submitted value included a trailing newline
| my $old_value = $changes->{cf_user_story}->[0]; | ||
| my $new_value = $changes->{cf_user_story}->[1]; |
There was a problem hiding this comment.
If the newline is stripped by the time it reaches this variable in Perl, could the issue be that the JS on the front-end is stripping the newline? Fixing it there is probably the more correct solution, but this works too and the bug probably doesn't warrant much more of a time investment. :)
There was a problem hiding this comment.
If the newline is stripped by the time it reaches this variable in Perl, could the issue be that the JS on the front-end is stripping the newline? Fixing it there is probably the more correct solution, but this works too and the bug probably doesn't warrant much more of a time investment. :)
Ideally that would be better but internally BMO is treating the user story field as any other freetext custom field. Therefore, before a value is stored in the DB it is trimmed of all whitespace at the beginning and end of the string. The regex used is /\s+$/ which also includes newlines as well as spaces. Rather than add a new data type just for story with a custom validation code function that doesn't remove newlines, it was simpler to just add the newline temporarily when doing the diff action.
I updated the code to add back the stripped newlines from the user story value before performing the diff if the newlines are missing. This fixes the issue with the warning being added to the diff output.