Update CMakeLists.txt #123
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minimum active ros2 (humble) require cxx 17 standard and cmake >=3.8. https://docs.ros.org/en/humble/The-ROS2-Project/Contributing/Code-Style-Language-Versions.html
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## ros2 #123 +/- ##
==========================================
+ Coverage 67.09% 68.92% +1.83%
==========================================
Files 3 4 +1
Lines 641 698 +57
Branches 0 87 +87
==========================================
+ Hits 430 481 +51
- Misses 211 213 +2
- Partials 0 4 +4 ☔ View full report in Codecov by Sentry. |
rhaschke
reviewed
May 15, 2024
Comment on lines
+4
to
8
| # Default to C++17 | ||
| if(NOT CMAKE_CXX_STANDARD) | ||
| set(CMAKE_CXX_STANDARD 14) | ||
| set(CMAKE_CXX_STANDARD 17) | ||
| endif() | ||
|
|
There was a problem hiding this comment.
I think you can drop the C++ standard definition completely, as C++17 is the default in Ubuntu 22 and later.
There was a problem hiding this comment.
Unfortunately, c++17 is not standard on all operating systems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minimum active ros2 (humble) require cxx 17 standard and cmake >=3.8.
https://docs.ros.org/en/humble/The-ROS2-Project/Contributing/Code-Style-Language-Versions.html