Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: chunked request blocked when proxy to upstream #2219

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dengqian
Copy link
Contributor

Issues associated with this PR

#2218

Solutions

You should show your solutions about the issues in your PR, including the overall solutions, details and the changes. At this time, Chinese is allowed to describe these.

UT result

Unit Test is needed if the code is changed, your unit test should cover boundary cases, corner cases, and some exceptional cases. And you need to show the UT result.

Benchmark

If your code involves the processing of every request, you should give the Benchmark Result.

Code Style

  • Make sure Goimports has run
  • Show Golint result

@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Base: 60.35% // Head: 60.30% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (5b788da) compared to base (b335823).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 5b788da differs from pull request most recent head d7a30de. Consider uploading reports for the commit d7a30de to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2219      +/-   ##
==========================================
- Coverage   60.35%   60.30%   -0.06%     
==========================================
  Files         422      422              
  Lines       37050    37051       +1     
==========================================
- Hits        22363    22345      -18     
- Misses      12466    12484      +18     
- Partials     2221     2222       +1     
Impacted Files Coverage Δ
pkg/stream/http/stream.go 35.02% <0.00%> (-0.08%) ⬇️
pkg/stream/stream.go 46.66% <0.00%> (-13.34%) ⬇️
pkg/stream/xprotocol/connpool_pingpong.go 50.00% <0.00%> (-12.11%) ⬇️
pkg/stream/xprotocol/conn.go 40.43% <0.00%> (-1.10%) ⬇️
pkg/module/http2/server.go 81.70% <0.00%> (-0.08%) ⬇️
pkg/module/http2/transport.go 78.91% <0.00%> (+0.14%) ⬆️
pkg/server/handler.go 40.50% <0.00%> (+0.71%) ⬆️
pkg/metrics/shm/zone.go 69.23% <0.00%> (+2.56%) ⬆️
pkg/mtls/sds/subscriber.go 78.43% <0.00%> (+3.92%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dengqian dengqian requested a review from 3062 January 12, 2023 09:21
Copy link
Contributor

@3062 3062 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doujiang24
Copy link
Member

@dengqian Nice catch, I think it fixed the bug, but I'm not sure it's the proper way.
@taoyuanyuan @nejisama may take a look~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants