Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize ut for Test_RouteRuleImplBase_finalizePathHeader #2213

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Atticusw
Copy link

@Atticusw Atticusw commented Jan 8, 2023

…zePathHeader

modify ut for pkg/router/base_rule_test.Test_RouteRuleImplBase_finalizePathHeader

Issues associated with this PR

Your PR should present related issues you want to solve.

Solutions

You should show your solutions about the issues in your PR, including the overall solutions, details and the changes. At this time, Chinese is allowed to describe these.

UT result

Unit Test is needed if the code is changed, your unit test should cover boundary cases, corner cases, and some exceptional cases. And you need to show the UT result.

Benchmark

If your code involves the processing of every request, you should give the Benchmark Result.

Code Style

  • Make sure Goimports has run
  • Show Golint result

…zePathHeader

modify ut for pkg/router/base_rule_test.Test_RouteRuleImplBase_finalizePathHeader
@mosn-community-bot
Copy link

Hi @Atticusw, welcome to mosn community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

Copy link
Contributor

@3062 3062 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Base: 60.33% // Head: 60.31% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (04cdb4f) compared to base (bbed393).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2213      +/-   ##
==========================================
- Coverage   60.33%   60.31%   -0.02%     
==========================================
  Files         420      422       +2     
  Lines       36966    37050      +84     
==========================================
+ Hits        22302    22346      +44     
- Misses      12445    12483      +38     
- Partials     2219     2221       +2     
Impacted Files Coverage Δ
pkg/istio/xds.go 84.61% <0.00%> (-1.99%) ⬇️
pkg/mosn/init.go 26.88% <0.00%> (-0.90%) ⬇️
pkg/upstream/healthcheck/healthchecker.go 88.65% <0.00%> (-0.32%) ⬇️
pkg/module/http2/server.go 81.70% <0.00%> (-0.15%) ⬇️
pkg/config/v2/config.go 61.11% <0.00%> (ø)
pkg/config/v2/upstream.go 69.33% <0.00%> (ø)
pkg/stagemanager/stage_manager.go 44.40% <0.00%> (ø)
pkg/upstream/healthcheck/healthchecklog.go 27.77% <0.00%> (ø)
pkg/upstream/cluster/lb_leastconnection.go 30.76% <0.00%> (ø)
pkg/module/http2/transport.go 79.05% <0.00%> (+0.14%) ⬆️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants