-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: data race #2177
base: master
Are you sure you want to change the base?
fix: data race #2177
Conversation
Codecov ReportBase: 60.48% // Head: 60.40% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2177 +/- ##
==========================================
- Coverage 60.48% 60.40% -0.09%
==========================================
Files 417 417
Lines 36598 36602 +4
==========================================
- Hits 22136 22108 -28
- Misses 12288 12313 +25
- Partials 2174 2181 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
LGTM. But one question, why there are two health checkers updating the flags concurrency? |
Maybe host object is the same one, but their address is the same one. example: there is two host that address is same. it's in two differet cluster and heathyChcker, so will currently update it's flag. |
two host objects that have the same address, still are two host objects? there won't be race? |
Issues associated with this PR
#2176
Solutions
You should show your solutions about the issues in your PR, including the overall solutions, details and the changes. At this time, Chinese is allowed to describe these.
UT result
Unit Test is needed if the code is changed, your unit test should cover boundary cases, corner cases, and some exceptional cases. And you need to show the UT result.
Benchmark
If your code involves the processing of every request, you should give the Benchmark Result.
Code Style
Goimports
has runGolint
result